Add column functions to check for valid date strings #144
+135
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghanse
requested review from
pratikk-databricks
and removed request for
a team
|
✅ 113/113 passed, 1 skipped, 24m39s total Running from acceptance #301 |
mwojtyczka
requested changes
Jan 31, 2025
|
@mwojtyczka made a few updates and resolved your comments, tests are succeeding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added the following column functions:
is_valid_dateis_valid_timestampUsers can specify the format as a string which should adhere to the Spark Datetime pattern specifications.
Linked issues
Resolves #143
Tests
Added
test_col_is_valid_dateandcol_is_valid_timestampfunctions to the integration tests.