Patch user agent #121
Merged
Patch user agent #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundarshankar89
requested review from
pratikk-databricks
and removed request for
a team
|
✅ 93/93 passed, 1 skipped, 31m49s total Running from acceptance #243 |
mwojtyczka
approved these changes
Jan 24, 2025
src/databricks/labs/dqx/base.py
Outdated
| @@ -18,9 +19,13 @@ def ws(self) -> WorkspaceClient: | |||
| @staticmethod | |||
| @final | |||
| def _verify_workspace_client(ws: WorkspaceClient) -> WorkspaceClient: | |||
| # pylint: disable=protected-access | |||
There was a problem hiding this comment.
no-cheat / no-pylint-disable step won't accept this. If there is absolutely no other way then reflection could help.
| @@ -21,6 +22,9 @@ def _verify_workspace_client(ws: WorkspaceClient) -> WorkspaceClient: | |||
| """ | |||
| Verifies the Databricks workspace client configuration. | |||
| """ | |||
| product_info = getattr(ws.config, '_product_info') | |||
There was a problem hiding this comment.
Please also add a comment that we need this for tracking the usage of DQX from notebooks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Linked issues
Resolves #..
Tests
Main:
After Applying Patch: