-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: CLI installation fails after lakeview api change #198
Labels
bug
Something isn't working
Comments
3 tasks
mwojtyczka
added a commit
that referenced
this issue
Feb 27, 2025
## Changes * Adjusted dashboard name to comply with new lakeview api rule regarding naming resources: must contain only alphanumeric characters (a-z, A-Z, 0-9), hyphens (-), or underscores (_) * Fixed tool demo * Split reference section for clarity * Provided minor doc updates ### Linked issues Resolves #171, #198 ### Tests - [x] manually tested - [ ] added unit tests - [ ] added integration tests
mwojtyczka
added a commit
that referenced
this issue
Feb 27, 2025
* Fixed cli installation and demo ([#177](#177)). In this release, changes have been made to adjust the dashboard name, ensuring compliance with new API naming rules. The dashboard name now only contains alphanumeric characters, hyphens, or underscores, and the reference section has been split for clarity. In addition, demo for the tool has been updated to work regardless if a path or UC table is provided in the config. Furthermore, documentation has been refactored and udpated to improve clarity. The following issue have been closed: [#171](#171) and [#198](#198). * [Feature] Update is_(not)_in_range ([#87](#87)) to support max/min limits from col ([#153](#153)). In this release, the `is_in_range` and `is_not_in_range` quality rule functions have been updated to support a column as the minimum or maximum limit, in addition to a literal value. This change is accomplished through the introduction of optional `min_limit_col_expr` and `max_limit_col_expr` arguments, allowing users to specify a column expression as the minimum or maximum limit. Extensive testing, including unit tests and integration tests, has been conducted to ensure the correct behavior of the new functionality. These enhancements offer increased flexibility when defining quality rules, catering to a broader range of use cases and scenarios.
Merged
mwojtyczka
added a commit
that referenced
this issue
Feb 27, 2025
* Fixed cli installation and demo ([#177](#177)). In this release, changes have been made to adjust the dashboard name, ensuring compliance with new API naming rules. The dashboard name now only contains alphanumeric characters, hyphens, or underscores, and the reference section has been split for clarity. In addition, demo for the tool has been updated to work regardless if a path or UC table is provided in the config. Furthermore, documentation has been refactored and udpated to improve clarity. The following issue have been closed: [#171](#171) and [#198](#198). * [Feature] Update is_(not)_in_range ([#87](#87)) to support max/min limits from col ([#153](#153)). In this release, the `is_in_range` and `is_not_in_range` quality rule functions have been updated to support a column as the minimum or maximum limit, in addition to a literal value. This change is accomplished through the introduction of optional `min_limit_col_expr` and `max_limit_col_expr` arguments, allowing users to specify a column expression as the minimum or maximum limit. Extensive testing, including unit tests and integration tests, has been conducted to ensure the correct behavior of the new functionality. These enhancements offer increased flexibility when defining quality rules, catering to a broader range of use cases and scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Current Behavior
There is a new requirement for lakeview api when creating dashboards. We currently use whitespaces which is not allowed anymore. During the installation the following error is thrown:
ERROR [d.l.blueprint.parallel][Installing_dashboards_0] Installing dashboards(PosixPath('/Users/marcin.wojtyczka/.databricks/labs/dqx/lib/src/databricks/labs/dqx/queries/quality/dashboard'), parent_path='/Users/[email protected]/.dqx/dashboards') task failed: validation failed: [resource names should only contain alphanumeric characters (a-z, A-Z, 0-9), hyphens (-), or underscores (_) [DQX Quality Dashboard]]: Traceback (most recent call last):
File "/Users/marcin.wojtyczka/.databricks/labs/dqx/state/venv/lib/python3.10/site-packages/databricks/labs/blueprint/parallel.py", line 158, in inner
Expected Behavior
The installation should not break
Steps To Reproduce
Install DQX using Databricks CLI.
Cloud
AWS
Operating System
macOS
Relevant log output
The text was updated successfully, but these errors were encountered: