Sample - Fix exports from Workspace to Windows FS #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
==========================================
+ Coverage 84.50% 84.84% +0.34%
==========================================
Files 42 42
Lines 3084 3135 +51
==========================================
+ Hits 2606 2660 +54
+ Misses 478 475 -3
Continue to review full report at Codecov.
|
|
@nfx I actually created this as a sample solution and didn't spend much time. I couldn't get back to it since then to finalize. Are we certain about the way I handled it (espc. regex)? |
This was referenced Jul 1, 2022
|
Was this merged intentionally? |
thaiphv
reviewed
Jul 12, 2022
| @@ -166,15 +168,16 @@ def import_workspace_dir(self, source_path, target_path, overwrite, exclude_hidd | |||
| 'continue.').format(cur_src, extensions)) | |||
|
|
|||
| def export_workspace_dir(self, source_path, target_path, overwrite, headers=None): | |||
| if os.path.isfile(target_path): | |||
| os_compatible_target_path = re.sub(LOCAL_OS_COMPATIBLE_PATH_REGEX, '_', target_path) | |||
There was a problem hiding this comment.
This will replace C:\\Users\\admin with C_Users\\admin. Effectively it converts an absolute path to a relative path.
pietern
added a commit
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.