Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up GeneratorBackend. #3673

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Clean up GeneratorBackend. #3673

merged 2 commits into from
Feb 23, 2024

Conversation

kallentu
Copy link
Member

  • Merge GeneratorBackend and GeneratorBackendBase. Removed GeneratorBackendBase essentially.
  • Moved all the documentation.
  • HtmlGeneratorBackend now extends GeneratorBackend
  • Removed generateConstant and generateTopLevelConstant. I really don't think we need this indirection.

In prep for #3667. Thought it'd be good to send this out on its own.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@kallentu kallentu requested a review from srawlins February 22, 2024 21:41
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Yes, this is definitely good as its own PR. Thanks!

@kallentu kallentu merged commit 0efd1b0 into main Feb 23, 2024
11 checks passed
@kallentu kallentu deleted the generatorbackend branch February 23, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants