Display null safety tag only on migrated packages #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scheglov
approved these changes
Oct 30, 2020
srawlins
approved these changes
Oct 30, 2020
| import 'package:dartdoc/src/quiver.dart' as quiver; | ||
| import 'package:dartdoc/src/package_config_provider.dart'; | ||
| import 'package:dartdoc/src/package_meta.dart' | ||
| show PackageMeta, PackageMetaProvider; | ||
| import 'package:dartdoc/src/render/renderer_factory.dart'; | ||
| import 'package:dartdoc/src/special_elements.dart'; | ||
| import 'package:meta/meta.dart'; | ||
| // TODO(jcollins-g): do not directly import path, use ResourceProvider instead |
There was a problem hiding this comment.
Ooh good call. I had an idea in my head to grep for path imports and clean them up.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2403. Filing #2410 for the port to AnalysisContextCollection originally anticipated to solve this, and #2409 for removing the null safety tag on individual symbols.
In addition to the end-to-end test, spot checked with
PACKAGE_NAME=collection PACKAGE_VERSION=1.15.0-nullsafety.4 grind serve-pub-packageandPACKAGE_NAME=collection grind serve-pub-packageand verified pages appeared correctly.