Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken main. #3195

Merged
merged 3 commits into from
Mar 10, 2025
Merged

Fix broken main. #3195

merged 3 commits into from
Mar 10, 2025

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Mar 10, 2025

https://github.com/dart-lang/dart-pad/actions/runs/13771805719/job/38511942985?pr=3195 :

Run dart run grinder build-project-templates
grinder running build-project-templates

build-project-templates
  flutter pub get:
    cwd: /home/runner/work/dart-pad/dart-pad/pkgs/dart_services/project_templates/dart_project
    env: {PUB_CACHE: /home/runner/work/dart-pad/dart-pad/pkgs/dart_services/local_pub_cache}
  Resolving dependencies...
  Because dartpad_sample depends on dio 5.8.0 which doesn't match any versions, version solving failed.
  
  
  You can try the following suggestion to make the pubspec resolve:
  * Try upgrading your constraint on dio: flutter pub add dio:'^5.8.0+1'
  Failed to update packages.

Bad state: pub get failed (1)
#0      ProjectCreator.buildDartProjectTemplate (package:dart_services/src/project_creator.dart:54:[7](https://github.com/dart-lang/dart-pad/actions/runs/13771805719/job/38511942985?pr=3195#step:8:8))
<asynchronous suspension>
#1      buildProjectTemplates (file:///home/runner/work/dart-pad/dart-pad/pkgs/dart_services/tool/grind.dart:90:3)
<asynchronous suspension>
#2      Grinder._invokeTask.<anon> (package:grinder/src/grinder.dart:221:24)
<asynchronous suspension>
#3      Future._kTrue (dart:async/future.dart:660:3)
<asynchronous suspension>
#4      _RootZone.bindUnaryCallbackGuarded.<anon> (dart:async/zone.dart:1[8](https://github.com/dart-lang/dart-pad/actions/runs/13771805719/job/38511942985?pr=3195#step:8:9)18:12)
<asynchronous suspension>

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/samples/lib/brick_breaker.dart
pkgs/samples/lib/fibonacci.dart
pkgs/samples/lib/google_ai.dart
pkgs/samples/lib/hello_world.dart
pkgs/samples/lib/main.dart
pkgs/samples/lib/sunflower.dart

@polina-c polina-c changed the title empty PR to verify state of main Empty PR to verify state of main Mar 10, 2025
@polina-c polina-c marked this pull request as ready for review March 10, 2025 19:54
@polina-c polina-c requested a review from devoncarew March 10, 2025 19:54
@polina-c polina-c changed the title Empty PR to verify state of main Fix broken main. Mar 10, 2025
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 - thanks for getting the bots green!

@polina-c polina-c merged commit dde4c03 into dart-lang:main Mar 10, 2025
14 checks passed
@polina-c polina-c deleted the emptypr branch March 10, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants