Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the samples regeneration validation #2875

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

devoncarew
Copy link
Member

  • fix the samples regeneration validation

Related to #2874 - I saw that the CI wasn't failing when it should have been.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew devoncarew requested a review from parlough February 27, 2024 21:05
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, nice catch!

@devoncarew devoncarew merged commit fa3de58 into main Feb 28, 2024
4 checks passed
@devoncarew devoncarew deleted the fix_samples_validation branch February 28, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants