#3057. Add reachability tests for operators. Part 5. #3105
Conversation
| C c = C(); | ||
| c >>= (i = 42); | ||
| } catch (_) {} | ||
| i; // Not definitely unassigned |
There was a problem hiding this comment.
Right, and we can't strengthen this one to use int i; and 'definitely assigned' because the constructor invocation C() could throw (or we could have out of memory).
So that's fine!
| /// @description Checks that if the static type of the expression of the form | ||
| /// `E1 >>= E2` static type of `E1`is not `Never` then `after(N) = after(E2)`. |
There was a problem hiding this comment.
I think this is similar to a case we had recently:
| /// @description Checks that if the static type of the expression of the form | |
| /// `E1 >>= E2` static type of `E1`is not `Never` then `after(N) = after(E2)`. | |
| /// @description Checks that for an expression of the form `E1 >>= E2`, | |
| /// if the static type of `E1`is not `Never` then `after(N) = after(E2)`. |
There was a problem hiding this comment.
Thank you. Fixed here and in the other tests.
| /// @description Checks that if the static type of the expression of the form | ||
| /// `E1 >>>= E2` static type of `E1`is not `Never` then `after(N) = after(E2)`. |
There was a problem hiding this comment.
Similar to TypeSystem/flow-analysis/reachability_A20_t108.dart.
| /// @description Checks that if the static type of the expression of the form | ||
| /// `E1 <<= E2` static type of `E1`is not `Never` then `after(N) = after(E2)`. |
There was a problem hiding this comment.
Similar to TypeSystem/flow-analysis/reachability_A20_t108.dart.
| /// @description Checks that if the static type of the expression of the form | ||
| /// `E1 <<= E2` static type of `E1`is not `Never` then `after(N) = after(E2)`. |
There was a problem hiding this comment.
Similar to TypeSystem/flow-analysis/reachability_A20_t108.dart.
| /// @assertion - Binary operator: All binary operators other than `==`, `&&`, | ||
| /// `||`, and `??` are handled as calls to the appropriate `operator` method. | ||
| /// | ||
| /// @description Checks that for an expression of the form `E1 >>>= E2` |
There was a problem hiding this comment.
I think a comma would improve on the readability of this sentence:
| /// @description Checks that for an expression of the form `E1 >>>= E2` | |
| /// @description Checks that for an expression of the form `E1 >>>= E2`, |
There was a problem hiding this comment.
I think this occurs in 7 tests in this PR.
There was a problem hiding this comment.
Fixed in all tests.
| /// `||`, and `??` are handled as calls to the appropriate `operator` method. | ||
| /// | ||
| /// @description Checks that if the static type of the expression of the form | ||
| /// `E1 >>>= E2` is `Never` `after(N) = unreachable(after(E2))`. |
There was a problem hiding this comment.
Again, the two code snippets right after each other looks funny, but a comma or 'then' could make it flow better:
| /// `E1 >>>= E2` is `Never` `after(N) = unreachable(after(E2))`. | |
| /// `E1 >>>= E2` is `Never` then `after(N) = unreachable(after(E2))`. |
I think we have about 5 of these in this PR.
There was a problem hiding this comment.
Fixed in all tests.
| @@ -0,0 +1,25 @@ | |||
| // Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file | |||
There was a problem hiding this comment.
Seems to be the same test as t119? Should perhaps be |=?
There was a problem hiding this comment.
Thank you for noticing!!! Fixed.
| @@ -0,0 +1,25 @@ | |||
| // Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file | |||
| @@ -0,0 +1,25 @@ | |||
| // Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file | |||
| /// @description Checks that if the static type of the expression of the form | ||
| /// `E1 >>= E2` static type of `E1`is not `Never` then `after(N) = after(E2)`. |
There was a problem hiding this comment.
Thank you. Fixed here and in the other tests.
| /// @assertion - Binary operator: All binary operators other than `==`, `&&`, | ||
| /// `||`, and `??` are handled as calls to the appropriate `operator` method. | ||
| /// | ||
| /// @description Checks that for an expression of the form `E1 >>>= E2` |
There was a problem hiding this comment.
Fixed in all tests.
| /// `||`, and `??` are handled as calls to the appropriate `operator` method. | ||
| /// | ||
| /// @description Checks that if the static type of the expression of the form | ||
| /// `E1 >>>= E2` is `Never` `after(N) = unreachable(after(E2))`. |
There was a problem hiding this comment.
Fixed in all tests.
| @@ -0,0 +1,25 @@ | |||
| // Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file | |||
There was a problem hiding this comment.
Thank you for noticing!!! Fixed.
| @@ -0,0 +1,25 @@ | |||
| // Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file | |||
| @@ -0,0 +1,25 @@ | |||
| // Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file | |||
No description provided.