Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2420. Add more dynamic semantics extension type tests #2459

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Jan 2, 2024

No description provided.

Typos: Remove empty line, add return type to `main`
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I adjusted a couple of typo-level things.

@eernstg eernstg merged commit bf785fe into dart-lang:master Jan 2, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jan 5, 2024
2024-01-05 [email protected] Fixes dart-lang/co19#2465. Fix roll failures (dart-lang/co19#2466)
2024-01-04 [email protected] dart-lang/co19#2420. Add object-pattern exhaustiveness tests (dart-lang/co19#2454)
2024-01-04 [email protected] dart-lang/co19#2420. Add relational pattern exhaustiveness tests (dart-lang/co19#2463)
2024-01-03 [email protected] dart-lang/co19#2420. Add missed experimental flags (dart-lang/co19#2462)
2024-01-03 [email protected] Fixes dart-lang/co19#2436. Add test for external constructors with initializers (dart-lang/co19#2461)
2024-01-02 [email protected] dart-lang/co19#2420. Add more dynamic semantics extension type tests (dart-lang/co19#2459)
2024-01-02 [email protected] Fixes dart-lang/co19#2436. Add tests for external and redirecting constructors with initializing formals (dart-lang/co19#2460)
2023-12-29 [email protected] dart-lang/co19#1400. Add object pattern tests for extension types (dart-lang/co19#2456)
2023-12-29 [email protected] dart-lang/co19#1400. Add type inference tests for extension types (dart-lang/co19#2455)
2023-12-29 [email protected] dart-lang/co19#2420. Add switch statement check to the existing exhaustiveness tests (dart-lang/co19#2452)

Change-Id: Iee0668f14a35bb3c47aa67b35b1e5c6d8abe8021
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345040
Reviewed-by: William Hesse <[email protected]>
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
@sgrekhov sgrekhov deleted the co19-2420-11 branch January 21, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants