Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2428. Add call member tests for extension types #2438

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Fixes #2428. Add call member tests for extension types #2438

merged 3 commits into from
Jan 9, 2024

Conversation

sgrekhov
Copy link
Contributor

No description provided.

eernstg
eernstg reviewed Dec 18, 2023
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think the @assertion needs to be revised in some of these tests. It describes invocations, not tear-offs. Another thing is that some tests are about a declaration that 'redeclares' call: They might benefit from including one more case.

sgrekhov
sgrekhov commented Dec 18, 2023
View reviewed changes
Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Please take another look

@sgrekhov sgrekhov requested a review from eernstg December 18, 2023 12:01
eernstg
eernstg approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit 155e055 into dart-lang:master Jan 9, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jan 12, 2024
@sgrekhov
[co19] Roll co19 to b5126f0bd51ea0819df8d5c362574f951a564940
f02b056 
2024-01-12 [email protected] Fixes dart-lang/co19#2480. Fix typos, add issue numbers (dart-lang/co19#2481)
2024-01-10 [email protected] dart-lang/co19#2477. Rename and reorder existing constants tests for match operators before adding new ones (dart-lang/co19#2478)
2024-01-10 [email protected] dart-lang/co19#2420. Add null-check-pattern tests for extension types (dart-lang/co19#2475)
2024-01-10 [email protected] dart-lang/co19#2119. Add missing experimental flags (dart-lang/co19#2474)
2024-01-10 [email protected] dart-lang/co19#2119. Fix typo and improve error messages in Timer tests (dart-lang/co19#2473)
2024-01-09 [email protected] Fixes dart-lang/co19#2471. Fix timer constructor tests. Add check for microtasks (dart-lang/co19#2472)
2024-01-09 [email protected] Fixes dart-lang/co19#2428. Add `call` member tests for extension types (dart-lang/co19#2438)
2024-01-09 [email protected] Fixes dart-lang/co19#2449. Update positions of analyzer expected errors (dart-lang/co19#2450)
2024-01-09 [email protected] Fixes dart-lang/co19#2440. Add asyncStart/End() to Stream interface tests (dart-lang/co19#2457)
2024-01-09 [email protected] dart-lang/co19#2420. Add another variable pattern exhaustiveness test (dart-lang/co19#2469)
2024-01-08 [email protected] dart-lang/co19#2420. Add constant pattern exhaustiveness tests (dart-lang/co19#2467)
2024-01-08 [email protected] dart-lang/co19#2436. Add expected constant evaluation error for CFE (dart-lang/co19#2470)
2024-01-08 [email protected] dart-lang/co19#2420. Add null-assert pattern exhaustiveness tests (dart-lang/co19#2468)
2024-01-05 [email protected] dart-lang/co19#2420. Add parenthesized pattern exhaustiveness tests (dart-lang/co19#2464)

Change-Id: I86862732cca7c042120bf312403279c2cc10c135
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345960
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
@sgrekhov sgrekhov deleted the co19-2428 branch January 21, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgrekhov @eernstg