Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An update in expected compile-time error messages emitted by the Analyzer is required after a change #2983

Closed
chloestefantsova opened this issue Nov 19, 2024 · 0 comments
Assignees
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@chloestefantsova
Copy link
Contributor

The following CL changed the emitted compile-time errors by the Analyzer: https://dart-review.googlesource.com/c/sdk/+/394140.

The following test should be updated: https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Extension-methods/generic_parameter_inference_A01_t05.dart

Currently expected error is at line 24, column 8, length 8: COMPILE_TIME_ERROR.COULD_NOT_INFER.

New error that should be expected is at line 24, column 17, length 2: COMPILE_TIME_ERROR.ARGUMENT_TYPE_NOT_ASSIGNABLE

@sgrekhov sgrekhov self-assigned this Nov 19, 2024
@sgrekhov sgrekhov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Nov 19, 2024
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 19, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 27, 2024
2024-11-25 [email protected] Fixes dart-lang/co19#2994. Fix a typo in type_void_A06_t11.dart (dart-lang/co19#2995)
2024-11-25 [email protected] dart-lang/co19#2559. Fix wrong assertion text in augmenting_constructors_A18_*.dart (dart-lang/co19#2993)
2024-11-25 [email protected] dart-lang/co19#2976. Add grammar tests (dart-lang/co19#2990)
2024-11-25 [email protected] Fixes dart-lang/co19#2991. Fix typos and separate tests with `external` (dart-lang/co19#2992)
2024-11-25 [email protected] dart-lang/co19#2559. Update assertions for some Augmenting libraries tests (dart-lang/co19#2989)
2024-11-21 [email protected] dart-lang/co19#2119. Update assertion texts in Wildcards tests (dart-lang/co19#2981)
2024-11-20 [email protected] dart-lang/co19#2956. Add more type `void` and `dynamic` tests (dart-lang/co19#2987)
2024-11-20 [email protected] dart-lang/co19#2979. Update existing and add new tests checking nnbd static errors (dart-lang/co19#2984)
2024-11-20 [email protected] dart-lang/co19#2979. Fix CFE failures in nnbd weak-mode tests (dart-lang/co19#2988)
2024-11-19 [email protected] dart-lang/co19#2956. Update and rename existing tests for type `void` (dart-lang/co19#2978)
2024-11-19 [email protected] dart-lang/co19#2559. Update assertions in some Augmenting libraries tests (dart-lang/co19#2986)
2024-11-19 [email protected] Fixes dart-lang/co19#2983. Change expected error in generic_parameter_inference_A01_t05.dart (dart-lang/co19#2985)
2024-11-18 [email protected] dart-lang/co19#2979. Update NNBD static errors tests. Part 2 (dart-lang/co19#2982)
2024-11-15 [email protected] dart-lang/co19#2979. Update NNBD static errors tests (dart-lang/co19#2980)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Ib1dcad2edfa7c6fdd996c6db94173bec91e68368
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397340
Commit-Queue: Alexander Thomas <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Development

No branches or pull requests

2 participants