Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative ratio less than epsilon to check zero. #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hongkai-dai
Copy link

In ccdVec3PointTriDist2, instead of checking if the triangle area is less than epsilon, we use the ratio (which measures the sine angle) less than epsilon to determine if the triangle area can be used as a denominator. This avoids the problem when CCD incorrectly doesn't trust the projection onto the interior of the triangle, and instead project to the edges of the triangle, causing bad witness point.

In ccdVec3PointTriDist2, instead of checking if the triangle area is less than epsilon, we use the ratio (which measures the sine angle) less than epsilon to determine if the triangle area can be used as a denominator. This avoids the problem when CCD incorrectly doesn't trust the projection onto the interior of the triangle, and instead project to the edges of the triangle, causing bad witness point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant