[WIP] Support for go1.8

[gernest]

This will eventually close #141`

[cznic]

I think the 'WIP' suggests to do the code review only once the PR is complete, right?

[gernest]

@cznic not really, mostly each commit is independent, and you can review as new commits comes in. Only merging has to wait until it is complete.

It will be really helpful to me if we review as I add new features so that by the end I wont have duplicate efforts for the case when I make bad choices.

For Instance, your feedback on the commits which add NamedArg support, can help clear that feature. I intend to work on adding support for canceling queries, which will probably cover the rest of go1.8 features.

[cznic]

Okay, thanks for letting me know. The plan is to clear the codereview queue this evening.

[cznic]

LGTM for 94b9de5

[cznic]

One small change please in e1046c1

[cznic]

s/+/ +/

cf.: https://golang.org/pkg/go/build/#hdr-Build_Constraints

[cznic]

LGTM, thank you.

[gernest]

Thanks. I will now see how I can introduce context.Context and enforce canceling of running queries.

[cznic]

I will now see how I can introduce context.Context and enforce canceling of running queries.

The row retrieving closure has to return more == false to stop the query:

ql/ql.go

Line 225 in eb22df2

// If f returns more == false or err != nil then f will not be called for any

[gernest]

@cznic neat trick

[OFFTOPIC] effectively testing the query cancelation I have to slow down queries, in postgres they use pg_sleep.

I already laid out the groundwork for supporting something like pg_sleep just wondering what will be a better name for the function sleep or ql_sleep?

I will submit a separate PR for the function

[gernest]

@cznic Can we just merge these changes?

I have hit a wall trying to make queries cancelable. When we come up with a way to halt execution maybe someone can pick it up from there.

[cznic]

Can we just merge these changes?

Yes.