refactor: Add GitDataSource, FileDataSource, toast for errors #18385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
lmiller1990
approved these changes
Oct 7, 2021
| dedupExchange, | ||
| errorExchange({ | ||
| onError (error) { | ||
| const message = ` |
There was a problem hiding this comment.
Nice, I wonder if we can adapt this pattern to something more general for any type of error.
There was a problem hiding this comment.
Yeah, this was only currently intended for errors in local dev since normal errors will have UI
ImCesar
approved these changes
Oct 7, 2021
tgriesser
requested review from
jennifer-shehane and
BlueWinds
and removed request for
a team
This reverts commit 12a8db4.
tgriesser
added a commit
that referenced
this pull request
Oct 10, 2021
* unified-desktop-gui: (40 commits) feat: index.html configurability and storybook support (#18242) fix: remove .json check from require_async, prevent child_process spawn (#18416) percy snapshot the tooltip visually, prevent it from being hidden fix: failing tests from #18372 (#18414) fix: `everyNthFrame` should only be applied for Chrome 89+ (#18392) feat(app): render spec list, command log, iframe (#18372) fix: drag and drop to be correct directory (#18400) refactor: Add GitDataSource, FileDataSource, toast for errors (#18385) docs: General updates to contributing guide (#18283) Add shorter --ct alias for --component Add --e2e and --component CLI options chore: Update Chrome (beta) to 95.0.4638.40 (#18389) chore: use circleci timings split for e2e tests (#18367) fix: fixed title (#18370) chore(deps): update dependency electron to v14 🌟 (#18384) chore(server): share client route (#18215) fix: Prevent Cypress from crashing when argument parsing "spec: {}" (#18312) chore: update husky dev dependency to v7 (#18345) feat: add defineConfig function to help type config (#18302) chore: Update Chrome (stable) to 94.0.4606.71 (#18324) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than having a random
utils/folder, for consistency decided to makeGitDataSource. Along those lines, moved the loader helpers intoUtilDataSource& file lookups intoFileDataSource.Also added a vue-toast util to show a helpful popup when we have a GraphQL error (intended for dev only)