fix: do not attempt to trim objects when printing to console

[cbolgiano]

• Closes Error when printing an object to the dev tools console #18143

User facing changelog

There should no longer be a javascript console error when converting a javascript object that is not an array and not null when the logger logs a value. Fixes issue 18143.

Additional details

The issue seemed to have been caused by how lodash handles objects in https://github.com/lodash/lodash/blob/2da024c3b4f9947a48517639de7560457cd4ec6c/.internal/baseToString.js#L29. The version of the function in the 4.17.21 tag looks like this https://github.com/lodash/lodash/blob/4.17.21/dist/lodash.js#L4298. Line 4298 is what we see in the video captured in this issue.

I changed

cypress/packages/runner-shared/src/logger.js

Line 27 in 1feb668

_logValues (consoleProps) {

to convert the javascript object to a string by calling JSON.stringify if it is an object that isn't null and not an array. This should prevent the error "Cannot convert object to primitive value" from occurring in the javascript console.

How has the user experience changed?

Should no longer show "Cannot convert object to primitive value" in the javascript console when the logger tries to output the string value of an javascript object that is not an array and is not null.

PR Tasks

• Has the original issue or this PR been tagged with a release in ZenHub?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[CLAassistant]

All committers have signed the CLA.

[cbolgiano]

Good evening! My apologies for the failing Semantic Pull Request. Please can someone help me understand how to get that green again? Thank you.

[cbolgiano]

I was able to find the document on the rules for the PR title.

[flotwig]

This change requires tests, one place you could put them would be here: https://github.com/cypress-io/cypress/blob/0964ca2c7d54c747bfae639fa4bda1cd86817f08/packages/runner-shared/src/logger.spec.js#L1-L17

You can run these tests via yarn test in packages/runner-shared

[cbolgiano]

Added unit test and refactored based on suggestion. This pull request is ready for review again. Thank you!

[cbolgiano]

It looks like the ci/circleci driver-integration-tests-chrome failed. I looked at the details and it looks like it might be a connection issue. How does one execute that job again to see if they pass this time?

[cbolgiano]

After pulling in the main line the checks are now all green!

[cbolgiano]

It looks like a e2e test failed. Need guidance on how to resolve if it is an issue. Thank you.

[cbolgiano]

Going to dive into the tests that failed this weekend.

[flotwig]

Going to dive into the tests that failed this weekend.

Those look like some flaky tests we've been dealing with lately. I'll rerun.

[cbolgiano]

Going to dive into the tests that failed this weekend.

Those look like some flaky tests we've been dealing with lately. I'll rerun.

Thank you! It looks like you were right.

[cbolgiano]

Please let me know if there is anything else I can do in order to get this accepted and merged. Thank you!

[flotwig]

Looks great. Thanks for the contribution @cbolgiano !

The base branch was changed.