fix: cy.intercept delay works correctly with 204 No Content #17126
Conversation
|
Thanks for taking the time to open a PR!
|
| function wait (fn, ms) { | ||
| return new Promise((resolve) => { | ||
| setTimeout(() => { | ||
| resolve(fn()) | ||
| }, ms) | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
What is the right place for this utility function?
There was a problem hiding this comment.
Bluebird offers Promise.delay which may meet your needs. If it's just used in this function/file then this is fine.
There was a problem hiding this comment.
I changed the code with Promise.delay.
There was a problem hiding this comment.
@sainthkh There seems to be a type error with the change
| function wait (fn, ms) { | ||
| return new Promise((resolve) => { | ||
| setTimeout(() => { | ||
| resolve(fn()) | ||
| }, ms) | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
Bluebird offers Promise.delay which may meet your needs. If it's just used in this function/file then this is fine.
|
@sainthkh Is this ready for rereview? |
sainthkh
force-pushed
the
issue-15188
branch
2 times, most recently
from
941601d to
09d78a3
Compare
|
I rolled back and decided to use |
User facing changelog
delaynow works correctly with thestatusCode: 204.Additional details
delaydidn't work correctly withstatusCode: 204.setTimeoutinside thegetBodyStream. It is called after the delay when response is not an empty body but it isn't when it's not. I fixed this by changinggetBodyStreamasasync.How has the user experience changed?
N/A
PR Tasks