aws: add support for elasticache resource #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talset
force-pushed
the
aws-elasticache
branch
3 times, most recently
from
5471097 to
baec2e1
Compare
talset
force-pushed
the
aws-elasticache
branch
5 times, most recently
from
6a029f9 to
f5212c5
Compare
talset
force-pushed
the
aws-elasticache
branch
4 times, most recently
from
1c6aff6 to
ea87064
Compare
talset
force-pushed
the
aws-elasticache
branch
from
ea87064 to
43b8957
Compare
To match CSV column and variable, rename: * PurchaseOption to PurchaseOption * TermPurchaseOption to TermType * startUsageAmount to startingRange
talset
force-pushed
the
aws-elasticache
branch
2 times, most recently
from
a51ce54 to
e59d32b
Compare
talset
force-pushed
the
aws-elasticache
branch
2 times, most recently
from
79d17df to
eaffe6d
Compare
To keep consistency between CSV value and query from resource implementation. Ingester will keep the same value from the CSV to the DB. it impact previous key/column names and on_demand/reserved value which actually is OnDemand and Reserved from the CSV. Column name will be change with field variable name when ingesting in the DB. Basically it is the name without spacies. Even if json accept space in key names, we choose to remove them for simplification reason.
Take care of the res.PriorCost() and res.PlannedCost() 2 returns.
xescugc
requested changes
Mar 22, 2022
xescugc
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for