providers: ignore "constraint providers" #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xescugc
reviewed
Sep 2, 2021
Comment on lines
+82
to
+78
| if prov != nil { | ||
| providers[name] = prov | ||
| } |
There was a problem hiding this comment.
Would be better maybe for this function to check?
if len(providers) == 0 {
return nil, ErrNoProviders
}
So then it's centralized
There was a problem hiding this comment.
Could be done at the end eventually yeah
xlr-8
force-pushed
the
hr-3070
branch
2 times, most recently
from
79bfd0a to
d0efbc6
Compare
Certain providers of Terraform are meant to specify constraint rather than locations/regions, etc. In cases where a provider doesn't contain a valid location, it will not be added to the list of valid providers, if no providers at all exist an error will be returned mentioning it.
xescugc
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain providers of Terraform are meant to specify constraint rather
than locations/regions, etc. In cases where a provider doesn't contain a
valid location, it will not be added to the list of valid providers, if
no providers at all exist an error will be returned mentioning it.