Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Currency on the results #48

Closed
xescugc opened this issue Jul 2, 2021 · 1 comment
Closed

Display Currency on the results #48

xescugc opened this issue Jul 2, 2021 · 1 comment
Assignees
@theskch
Labels
enhancement New feature or request

Comments

@xescugc
Copy link
Member

xescugc commented Jul 2, 2021

We are storing the currency to the DB but it's not using it anywhere right now, from a caller PoV then the prices are just numbers without a reference.

For me this info is lost on the cost.NewState https://github.com/cycloidio/terracost/blob/master/cost/state.go#L68 as we are not setting the currency but the other values. Once it's inside of the Component I think it'll be dragged everywhere else.
@xescugc xescugc added the enhancement New feature or request label Jul 2, 2021
@theskch theskch self-assigned this Jul 5, 2021
theskch added a commit that referenced this issue Jul 7, 2021
@theskch
changelog: entry for issue #48
e131c44
@theskch theskch mentioned this issue Jul 7, 2021
Merged
theskch added a commit that referenced this issue Jul 9, 2021
@theskch
changelog: entry for issue #48
16bed1f
@theskch
Copy link
Contributor

theskch commented Jul 14, 2021

Closed by PR #49

@theskch theskch closed this as completed Jul 14, 2021
@theskch theskch mentioned this issue Jul 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theskch theskch

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xescugc @theskch