Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws: aws_db_parameter_group + aws CONTRIBUTING.md doc #78

Merged
merged 11 commits into from
Jan 22, 2020
Merged

aws: aws_db_parameter_group + aws CONTRIBUTING.md doc #78

merged 11 commits into from
Jan 22, 2020

Conversation

talset
Copy link
Member

@talset talset commented Dec 23, 2019 •
edited
Loading

Add

  • aws_db_parameter_group resource
  • aws_iam_access_key
  • aws_cloudwatch_metric_alarm
  • aws_autoscaling_policy
  • aws_iam_user_ssh_key

Update the CONTRIBUTING doc with a "howto" on adding new aws resource

@talset talset force-pushed the fl-aws_db_parameter_group branch 8 times, most recently from 1df0ed9 to 9c70621 Compare December 27, 2019 16:13
sdurrheimer
sdurrheimer reviewed Dec 30, 2019
View reviewed changes
sdurrheimer
sdurrheimer reviewed Dec 30, 2019
View reviewed changes
sdurrheimer
sdurrheimer reviewed Dec 30, 2019
View reviewed changes
xescugc
xescugc requested changes Jan 2, 2020
View reviewed changes
Copy link
Member

@xescugc xescugc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK if it's ready to review or not (no label) but remember this commit f744835

tormath1
tormath1 reviewed Jan 7, 2020
View reviewed changes
@talset talset force-pushed the fl-aws_db_parameter_group branch 4 times, most recently from 8cc3fb0 to d4fc905 Compare January 8, 2020 09:40
@talset talset changed the title aws: aws_db_parameter_group + aws CONTRIBUTING.md doc aws: aws_db_parameter_group + aws CONTRIBUTING.md doc [in progress] Jan 9, 2020
talset added 7 commits January 15, 2020 10:13
@talset
aws: make generate
3c8ab13 
Generate aws/reader/reader.go
         aws/resourcetype_enumer.go
@talset
CONTRIBUTING.md: aws how to
c0e009f 
Based on aws_db_parameter_group, add a howto for not specific implementation.
@talset
aws: add aws_iam_access_key
21055f8
@talset
aws: add iamUserSshKeys (in progress)
47c8eeb
@talset
aws: add aws_cloudwatch_metric_alarm
e2aa612
@talset
aws: add aws_autoscaling_policy
d725828 
And fix naming for LC LT
@talset
aws: add aws_iam_user_ssh_key
4761b63
@talset talset force-pushed the fl-aws_db_parameter_group branch from d4fc905 to 4761b63 Compare January 15, 2020 09:13
@talset talset changed the title aws: aws_db_parameter_group + aws CONTRIBUTING.md doc [in progress] aws: aws_db_parameter_group + aws CONTRIBUTING.md doc Jan 15, 2020
@talset talset merged commit 8ff6087 into master Jan 22, 2020
@talset talset deleted the fl-aws_db_parameter_group branch January 22, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdurrheimer sdurrheimer sdurrheimer left review comments

@tormath1 tormath1 tormath1 left review comments

@xescugc xescugc xescugc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@talset @xescugc @sdurrheimer @tormath1 @xlr-8