Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all terraform providers #264

Merged
merged 8 commits into from
Apr 20, 2022
Merged

Update all terraform providers #264

merged 8 commits into from
Apr 20, 2022

Conversation

talset
Copy link
Member

@talset talset commented Mar 29, 2022 •
edited by xlr-8
Loading

Update the aws/google provider version and write a how to update doc

Closes: #279

@talset talset added Type: Docs Documentation of any type (source, architecture, etc.) Type: Enhancement Provide a new feature or improve an existing one Status: In progress labels Mar 29, 2022
@talset talset self-assigned this Mar 29, 2022
xescugc
xescugc requested changes Mar 30, 2022
View reviewed changes
Copy link
Member

@xescugc xescugc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog entry.

@talset talset force-pushed the fl-awsupdate branch 5 times, most recently from 2959e39 to 4cb492e Compare April 6, 2022 16:02
@talset talset requested a review from xescugc April 7, 2022 07:25
@talset talset changed the title aws: update terraform provider aws/google: update terraform provider Apr 7, 2022
@xescugc xescugc changed the title aws/google: update terraform provider Update all terraform providers Apr 7, 2022
xescugc
xescugc reviewed Apr 7, 2022
View reviewed changes
talset added 5 commits April 7, 2022 17:33
@talset
azurerm: update contrib doc regarding missing version change
2c2231f
@talset
aws: update terraform provider
5c60ce7
@talset
CONTRIBUTING: How to update terraform-provider-aws
af37aff 
Document how to update AWS provider

Add scripts/terraform-provider-update/update.sh used by the Makefile to
automate provider update.
@talset
CHANGELOG.md: update
2cd0040
@talset
hcl/writer_test: aws provider removed region as required
0b173e0 
Remove region attribute since it is not required anymore on the provider
definition.
By default we don't write it anymore.
@talset talset requested a review from xescugc April 8, 2022 13:48
xescugc
xescugc reviewed Apr 11, 2022
View reviewed changes
Copy link
Member

@xescugc xescugc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thik we should add a comment on the How to update terraform-provider-aws that only people from Cycloid will be able to do that, if not open an issue asking for it, just to have it clear.

@talset
Copy link
Member Author

talset commented Apr 11, 2022

I thik we should add a comment on the How to update terraform-provider-aws that only people from Cycloid will be able to do that, if not open an issue asking for it, just to have it clear.

You are right. For GCP this is fine (since we don't need to fork it). But AWS&Azure they can't. Will update the docs

@xlr-8 xlr-8 mentioned this pull request Apr 12, 2022
Closed
@talset
CONTRIBUTING: How to update terraform-provider-google
2cbba28 
Update the CONTRIBUTING.md and terraform-provider-update/update.sh
regarding google.
@talset
Copy link
Member Author

talset commented Apr 15, 2022

Doc updated for aws & azurerm

@talset talset requested a review from xescugc April 19, 2022 11:47
@talset talset merged commit f2caedb into master Apr 20, 2022
@talset talset deleted the fl-awsupdate branch April 20, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xescugc xescugc xescugc approved these changes

Assignees

@talset talset

Labels
Type: Docs Documentation of any type (source, architecture, etc.) Type: Enhancement Provide a new feature or improve an existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure: upgrade SDK
3 participants
@talset @xescugc @xlr-8