Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm&gcp: do not stop when service not enable fix #247 #257

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Conversation

talset
Copy link
Member

@talset talset commented Feb 10, 2022

With a valid credential, terracognita should import everything possible and not stop.

We filter the error from Cloud Provider and return a custom error type if it's an error that we want to skip

Fix #247

we filter the error from Azure and return a custom error
type if it's an error that we want to skip
@talset talset added Provider: AzureRM Provider: GCP Issues related to the GCP Provider Status: Need review Type: Enhancement Provide a new feature or improve an existing one labels Feb 10, 2022
Copy link
Member

@xescugc xescugc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a changelog.

@talset
Copy link
Member Author

talset commented Feb 22, 2022

changelog added

@talset talset merged commit 742682f into master Mar 9, 2022
@talset talset deleted the fl-247 branch March 9, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Provider: AzureRM Provider: GCP Issues related to the GCP Provider Type: Enhancement Provide a new feature or improve an existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure & gcp: do not stop when service not enable, 404 or not enough permission
3 participants