Changed: Provider and Terraform versions #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok ready to review. |
kerak19
requested changes
Nov 5, 2020
|
Done |
|
RS |
…dencies Updating the TF versions means that some of the APIs do not work anymore and we have to fix them
TF to 0.13.5-cy AWS to 3.1.0 AZ to 2.34.0 GCP to 3.40
To be the new ones we have updated to
kerak19
approved these changes
Nov 6, 2020
So if they are not defined it'll fail so we basically have to skip if no DomainNames
As it'll cause weird errors in terms of not actually replacing what we wanted
tormath1
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically updated the versions of the Provieders and TF.
TF: 0.13.5-cy
AWS: 3.1.0
AZ: 2.34.0
GCP: 3.40.0
We cannot update to the latest version as they require the TF-SDK version v2 which is not compatible with the code we have right now.
I'll work to solve that problem too.