hcl: avoid mutual interpolation #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormath1
added
Type: Enhancement
tormath1
changed the title
xescugc
requested changes
Jul 1, 2020
hcl/writer.go
Outdated
Comment on lines
218
to
227
| func isMutualInterpolation(target, source string, relations *[][]string) bool { | ||
| for _, r := range *relations { | ||
| if (r[0] == target && | ||
| r[1] == source) || | ||
| (r[1] == target && | ||
| r[0] == source) { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } |
There was a problem hiding this comment.
I think it would be better to have a map[string]struct{} where the key is source+target, so we can easily check without iterating over all the array.
Also document what is what.
There was a problem hiding this comment.
it's documented 🤔
// isMutualInterpolation will simply go through the list of relations to find out
// if a relation is already present between the two resources
|
@xescugc it's done :) |
xescugc
reviewed
Jul 2, 2020
Comment on lines
+219
to
+224
| func isMutualInterpolation(target, source string, relations *map[string]struct{}) bool { | ||
| if _, ok := (*relations)[fmt.Sprintf("%s+%s", source, target)]; ok { | ||
| return true | ||
| } | ||
| if _, ok := (*relations)[fmt.Sprintf("%s+%s", target, source)]; ok { | ||
| return true |
There was a problem hiding this comment.
We actually do not need the + on the interpolation, it's more up to you if you want.
There was a problem hiding this comment.
what do you mean ? the + is just a way to create the key in the relations map 🤔
this kind of interpolation (between 2 resources) leads to cyclic references at TF runtime. To avoid it, we build a list of current relations between resources then we check if a relation is already present before adding a ref to another resource
tormath1
force-pushed
the
mt-fix-interpolation
branch
from
7c9fe4d to
74a0fc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this kind of interpolation (between 2 resources) leads to cyclic references at TF runtime. To avoid it, we build a list of current relations between resources then we check if a relation is already present before adding a ref to another resource