Fix: Pagination and nil pointer errors #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormath1
approved these changes
Jul 1, 2020
|
You can RS |
Was not reassigning the log correctly and each resource had the name of the previous resource also on the log which made the logs really hard to read if it was a long import
Some of theme where not using the rignt 'NextToken' if available
Actions to nested attributes now will be validated that the first attribute exists and it's not nil before trying to access it. This way we do not get a null pointer
The resources that only have one value where not validated if the value actually existed before unreferencing it, so if it was nil an error was returned
And also the new template format
tormath1
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the paginations where not using the right "format" (most of them had the
Next*and was not used).Also fixed the templates to validate nil objects before trying to access and the same on the resources.