This repository was archived by the owner on Mar 31, 2023. It is now read-only.
Use buffered channel for signal.Notify #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daichimukai
force-pushed
the
fix-signal-notify-chan
branch
from
1e8a9e3 to
578b5b1
Compare
|
I've pushed an empty commit and removed it to melt the frozen workflow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The channel for
signal.Notifymust not block; use buffered channel as documented. Found bygo vet ./....$ go vet ./... # github.com/cybozu-go/log/testcmd testcmd/main.go:33:3: misuse of unbuffered os.Signal channel as argument to signal.NotifyIf this is intentional, we should add comment.