This repository was archived by the owner on Mar 31, 2023. It is now read-only.
Fix JSONFormat to output valid JSON strings #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itchyny
force-pushed
the
fix-json-string
branch
2 times, most recently
from
77a0232 to
416cf74
Compare
itchyny
force-pushed
the
fix-json-string
branch
2 times, most recently
from
a662d91 to
46a9527
Compare
itchyny
commented
Jan 20, 2023
| @@ -316,3 +307,53 @@ func appendFloat(buf []byte, v float64, bitSize int) []byte { | |||
| return strconv.AppendFloat(buf, v, 'f', -1, bitSize) | |||
| } | |||
| } | |||
|
|
|||
| // Ref: encodeState#string in encoding/json. | |||
There was a problem hiding this comment.
This implementation might look kind of a horrible idea causing code duplicates, but I don't think there's a better way to solve the original issue with no allocation overhead. I hope there is json.AppendMarshal([]byte, v any) ([]byte, error) in encoding/json package.
There was a problem hiding this comment.
Another solution is to create a writer wrapping a bytes.Buffer to use json.Encoder.Encode, just like I'm proposing in different package (https://github.com/hokaccha/go-prettyjson/pull/21/files#diff-2fc4cc94d53b67bb93f26e56ef7ee4b2344b0b20970b9b971cbf418f4fc31818R233-R244), but this is actually slower than directly appending to []byte for maximum performance like this log package.
itchyny
force-pushed
the
fix-json-string
branch
from
46a9527 to
b6dde1a
Compare
morimoto-cybozu
suggested changes
Jan 23, 2023
morimoto-cybozu
approved these changes
Jan 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes JSONFormat to output valid JSON strings regardless of the fields data, resolves #31.