This repository was archived by the owner on Mar 31, 2023. It is now read-only.
Fix JSONFormat to ensure outputting JSON on NaN and Infinities #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently (v1.6.1)
JSONFormat
emits non-JSON on NaN and Infinities.This PR fixes
JSONFormat
to ensure the output to be JSON on NaN and Infinities.Also added tests for
Logfmt
andPlainFormat
to cover these values (behavior not changed).Sample code
Result
Expected behavior
I expect this logger either to emit valid JSON or to return error.
Considering the expectation against loggers, I think it is better to emit JSON to allow restoration of the original data.
encoding/json
: Losing log data on invalid data is unacceptable as a logger."NaN"
,"+Inf"
,"-Inf"
likezap
: Allows restoration of the original data, except for the confusion against string values.null
,1.7976931348623157e+308
,-1.7976931348623157e+308
likejq
: Familiar behavior of jq user, and keeps the number type, but cannot distinguishnull
andNaN
and this is confusing.