Dl/stream export project #9159
Open
Dl/stream export project #9159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiltsov-max
reviewed
Mar 4, 2025
| self._include_images = include_images | ||
| self._grouped_by_frame = list(instance_data.group_by_frame(include_empty=True)) |
There was a problem hiding this comment.
Probably, we can call this function in the __iter__ method for streaming cases, otherwise it will keep all the annotations in memory.
There was a problem hiding this comment.
well, these annotations will be kept in memory during __iter__ anyway, and I did not find another simple way to get number of items for project.
Also, I am redesigning this PR a bit because I missed that on streaming export items are iterated more than once for multi-subset projects
# Conflicts: # cvat/apps/dataset_manager/bindings.py
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Streaming export for project extractor, and since CvatTaskOrJobDataExtractor and CVATProjectDataExtractor are almost the same, extracting common base class for them
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.