Rails 8 Compatibility (PR attached) #589
Comments
4 tasks
tagliala
added a commit
to tagliala/cucumber-rails
that referenced
this issue
Nov 10, 2024
- Conditionally load the sqlite3 gem based on the Rails version. - Simplify error page assertions to account for variations in apostrophes, as "We're sorry" changed to "We`re sorry" in Rails 8. Close cucumber#589
tagliala
added a commit
to tagliala/cucumber-rails
that referenced
this issue
Nov 10, 2024
- Conditionally load the sqlite3 gem based on the Rails version. - Simplify error page assertions to account for variations in apostrophes, as "We're sorry" changed to "We`re sorry" in Rails 8. Close cucumber#589
tagliala
added a commit
to tagliala/cucumber-rails
that referenced
this issue
Nov 10, 2024
- Conditionally load the sqlite3 gem based on the Rails version. - Simplify error page assertions to account for variations in apostrophes, as "We're sorry" changed to "We`re sorry" in Rails 8. Close cucumber#589
|
Will look to get on this in the next few days @tagliala |
tagliala
added a commit
to tagliala/cucumber-rails
that referenced
this issue
Nov 12, 2024
- Conditionally load the sqlite3 gem based on the Rails version. - Simplify error page assertions to account for variations in apostrophes, as "We're sorry" changed to "We`re sorry" in Rails 8. Close cucumber#589
tagliala
added a commit
to tagliala/cucumber-rails
that referenced
this issue
Nov 13, 2024
In specific: - Do not test Rails 7.0 against 3.3 - Allow 8.0 in gemspec, by relaxing the upper constraint to `< 8.1`. Rails uses shifted SemVer, so `8.1` is considered a Major. - Conditionally load the sqlite3 gem based on the Rails version. - Conditionally load selenium webdriver gem based on the Rails version. - Simplify error page assertions to account for variations in apostrophes, as "We're sorry" changed to "We`re sorry" in Rails 8. References: - https://guides.rubyonrails.org/maintenance_policy.html#versioning - rails/rails#53045 Close cucumber#589
tagliala
added a commit
to tagliala/cucumber-rails
that referenced
this issue
Nov 21, 2024
In specific: - Do not test Rails 7.0 and 7.1 against 3.3 - Allow 8.0 in gemspec, by relaxing the upper constraint to `< 9`. Rails uses shifted SemVer, so `8.1` is considered a Major, but it has been decided to use `< 9` anyway - Conditionally load the sqlite3 gem based on the Rails version. - Conditionally load selenium webdriver gem based on the Rails version. - Simplify error page assertions to account for variations in apostrophes, as "We're sorry" changed to "We`re sorry" in Rails 8. References: - https://guides.rubyonrails.org/maintenance_policy.html#versioning - rails/rails#53045 Close cucumber#589
|
Any updates on this or when it will be posted? Is it a time issue or are there compatibility issues? |
|
It'll be merged and a release will be cut soon |
luke-hill
pushed a commit
that referenced
this issue
Nov 21, 2024
In specific: - Do not test Rails 7.0 and 7.1 against 3.3 - Allow 8.0 in gemspec, by relaxing the upper constraint to `< 9`. Rails uses shifted SemVer, so `8.1` is considered a Major, but it has been decided to use `< 9` anyway - Conditionally load the sqlite3 gem based on the Rails version. - Conditionally load selenium webdriver gem based on the Rails version. - Simplify error page assertions to account for variations in apostrophes, as "We're sorry" changed to "We`re sorry" in Rails 8. References: - https://guides.rubyonrails.org/maintenance_policy.html#versioning - rails/rails#53045 Close #589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🤔 What's the problem you're trying to solve?
Upgrading to Rails 8.0
✨ What's your proposed solution?
Update gemspec
⛏ Have you considered any alternatives or workarounds?
No response
📚 Any additional context?
No response
The text was updated successfully, but these errors were encountered: