Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Significantly reduce the size of the html report #2172

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

mpkorstanje
Copy link
Contributor

Cucumber-JVM will emit all step, hook and parameter type definition for each
scenario. This results in a deluge of messages that effectively grows with
the square of the number of scenarios (more scenarios, result in more step
definitions).

Executing some 500 scenarios can result in a html report anywhere between
150 and 300 MiB. The step, hook, and parameter type definitions are not used
by the html report and can be filtered out. This reduces the report size to
some 15 MiB. While still large this is much more manageable.

Further reductions will have to come from:

  1. Improvements to cucumber/react
  2. Fixing Cucumber JVM to only define steps, hooks and parameter types once.

See: https://github.com/cucumber/cucumber/issues/1232https://github.com/cucumber/cucumber/issues/1232

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #2172 (ae11dbc) into main (3bc6e77) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #2172   +/-   ##
=========================================
  Coverage     82.79%   82.79%           
- Complexity     2321     2324    +3     
=========================================
  Files           306      306           
  Lines          8292     8294    +2     
  Branches        762      762           
=========================================
+ Hits           6865     6867    +2     
  Misses         1118     1118           
  Partials        309      309           
Impacted Files Coverage Δ Complexity Δ
...in/java/io/cucumber/core/plugin/HtmlFormatter.java 76.47% <100.00%> (+3.13%) 7.00 <5.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc6e77...f328000. Read the comment docs.

Cucumber-JVM will emit all step, hook and parameter type definition for each
scenario. This results in a deluge of messages that effectively grows with
the square of the number of scenarios (more scenarios, result in more step
definitions).

Executing some 500 scenarios can result in a html report anywhere between
150 and 300 MiB. The step, hook, and parameter type definitions are not used
by the html report and can be filtered out. This reduces the report size to
some 15 MiB. While still large this is much more manageable.

Further reductions will have to come from:

1. Improvements to `cucumber/react`
2. Fixing Cucumber JVM to only define steps, hooks and parameter types once.
@mpkorstanje mpkorstanje merged commit 5f51c96 into main Nov 12, 2020
@mpkorstanje mpkorstanje deleted the cucumber/1232 branch November 12, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant