Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: use kebab-case for --retry-tag-filter arg #1293

Merged
merged 14 commits into from
Mar 17, 2020
+55 −17
Merged

cli: use kebab-case for --retry-tag-filter arg #1293

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c6ff308
update error message
davidjgoss Feb 20, 2020
0dfedec
switch to kebab-case
davidjgoss Feb 20, 2020
4ab6d6f
issue warning when using camel case for --retry-tag-filter; make warn…
davidjgoss Feb 22, 2020
70ee175
update docs to reference correct case
davidjgoss Feb 22, 2020
04db71c
whoops remove arg we dont need
davidjgoss Feb 22, 2020
0595d27
remove arg we dont need
davidjgoss Feb 22, 2020
eb91517
create a console from stdout and warn using that
davidjgoss Feb 27, 2020
a9dea8c
log warnings to stderr not stdout
davidjgoss Mar 7, 2020
3dc5293
pass both stdout and stderr to console
davidjgoss Mar 7, 2020
7ded1ce
merge from master
davidjgoss Mar 7, 2020
2fdd094
rework again, do linting in argv parser
davidjgoss Mar 13, 2020
6ee7526
simplify
davidjgoss Mar 17, 2020
5734c40
Merge branch 'master' into retry-tag-filter-case
davidjgoss Mar 17, 2020
dae8a70
update CHANGELOG.md
davidjgoss Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
whoops remove arg we dont need
@davidjgoss
davidjgoss committed Feb 22, 2020
commit 04db71c301a8e04dfb257b41a1e1940c85eae54a
4 changes: 2 additions & 2 deletions src/cli/argv_parser.ts
View file
Original file line number Diff line number Diff line change
@@ -90,7 +90,7 @@ const ArgvParser = {
return value
},

validateRetryOptions(argv: string[], options: IParsedArgvOptions): void {
validateRetryOptions(options: IParsedArgvOptions): void {
if (options.retryTagFilter !== '' && options.retry === 0) {
throw new Error(
'a positive --retry count must be specified when setting --retry-tag-filter'
@@ -217,7 +217,7 @@ const ArgvParser = {

program.parse(argv)
const options = program.opts() as IParsedArgvOptions
ArgvParser.validateRetryOptions(argv, options)
ArgvParser.validateRetryOptions(options)

return {
options,