Skip to content

Add eslint #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 11, 2015
Merged

Add eslint #41

merged 4 commits into from
Sep 11, 2015

Conversation

joeybaker
Copy link
Contributor

Adds, configures, and fixes problems for eslint. I tried to configure it to match the code style already present.

@joshwnj
Copy link
Member

joshwnj commented Sep 11, 2015

Good idea, thanks. However I wonder if we might be best to use https://github.com/feross/standard ? It's not all of my personal preferences but seems like a good way to set neutral ground for OS projects.

Merging this now anyway because it's an improvement, but might switch to standard later :)

joshwnj added a commit that referenced this pull request Sep 11, 2015
@joshwnj joshwnj merged commit d44b762 into css-modules:master Sep 11, 2015
@joshgillies
Copy link
Member

+1 to Standard. I've been using it on all my other projects, and really
like it as a drop linting solution.
On 12 Sep 2015 06:34, "Josh Johnston" [email protected] wrote:

Merged #41 #41.


Reply to this email directly or view it on GitHub
#41 (comment).

@joeybaker joeybaker deleted the add-linter branch September 11, 2015 21:04
@joeybaker
Copy link
Contributor Author

I'm cool with Standard! It would be mean removing the semi-colons, but I'm cool with that! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants