Skip to content

CW2-3 Add events section #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 12, 2024
Merged

CW2-3 Add events section #4

merged 5 commits into from
Apr 12, 2024

Conversation

QuadAces
Copy link
Contributor

@QuadAces QuadAces commented Apr 4, 2024

Why the changes are required?

To add an events section with content

Changes

  • Changed events component with the same text as the old website
  • Added a placeholder for potential events images

Screenshots

Screenshot 2024-04-04 at 7 20 45 pm ### Comments - Is not fit for deployment, will require the Facebook API/events to replace the "placeholder"

Copy link
Contributor

@derekxu04 derekxu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just one quick change:

Could you ensure that clicking the sections on the navbar at the top scrolls to the relevant section

Copy link
Contributor

@derekxu04 derekxu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@derekxu04 derekxu04 merged commit 3fa4d93 into master Apr 12, 2024
@derekxu04 derekxu04 deleted the CW2-3_Add_Events_Section branch April 12, 2024 14:00
derekxu04 added a commit that referenced this pull request Apr 18, 2024
* changed the h1 tags

* changed image alt tags

* changed tailwind

* CW2-3 Add events section (#4)

* added events template

* removed section

* modified events to coordinate with navbar on click

---------

Co-authored-by: Stuart Cutbush <[email protected]>
Co-authored-by: Derek Xu <[email protected]>

* changes to make linter approve

* formatted code?

---------

Co-authored-by: Stuart Cutbush <[email protected]>
Co-authored-by: Derek Xu <[email protected]>
PenTest-duck pushed a commit that referenced this pull request May 30, 2024
* added events template

* removed section

* modified events to coordinate with navbar on click

---------

Co-authored-by: Stuart Cutbush <[email protected]>
Co-authored-by: Derek Xu <[email protected]>
PenTest-duck pushed a commit that referenced this pull request May 30, 2024
* changed the h1 tags

* changed image alt tags

* changed tailwind

* CW2-3 Add events section (#4)

* added events template

* removed section

* modified events to coordinate with navbar on click

---------

Co-authored-by: Stuart Cutbush <[email protected]>
Co-authored-by: Derek Xu <[email protected]>

* changes to make linter approve

* formatted code?

---------

Co-authored-by: Stuart Cutbush <[email protected]>
Co-authored-by: Derek Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants