Fix missing self arguments in Flask __init__ replacement #82
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Damn it! I was too rushed and missed the (obvious) 2nd spot. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 3245685 broke the CS50 Flask monkey-patch, due to a missing
selfargument when swapping the__init__functions offlask.Flaskwith both_beforeand_after. As such, they getNameError: name 'self' is not definedwhen running the app.See https://www.reddit.com/r/cs50/comments/cbez89/finance_nameerror_name_self_is_not_defined/ to find users using the CS50 IDE facing issues with Flask.
This commit adds both
selfarguments into both_beforeand_after, fixing the issue.This fix has been tested to work with pset7 similarities, and should fix the other psets that require the use of Flask as well.