-
Notifications
You must be signed in to change notification settings - Fork 280
adds support for other paramstyles, disables logging by default when Flask not running #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added some test cases for qmark, named, and numeric on SQLite.
@kzidane just added some checks to require that no passed-in values can go unused, whether using positional placeholders or named ones if you'd like to try this out before we ship. |
@dmalan just uncommented my test cases. Should be good if all green. |
@dmalan looks like it passed. |
Previously, we only supported a
paramstyle
ofnamed
, https://www.python.org/dev/peps/pep-0249/#paramstyle. This adds support for all otherparamstyle
values as well as multiple calling conventions: