s/isinstance/type/

[kzidane]

No description provided.

[dmalan]

Good catch. Is == definitely best as opposed to is (not isinstance)?

[kzidane]

@dmalan I think they're practically the same in this case. Changed to is for readability.

[dmalan]

Does practically mean there's some difference though?

[kzidane]

Well, yes. == checks if two values are the same while is checks if two instances are the same. If two values are equal, that doesn't necessarily mean that they're the same instance.

>>> ls = [1, 2, 3]
>>> lss = [1, 2, 3]
>>> ls == lss
True
>>> ls is lss
False

[dmalan]

Right, but what does "practically the same in this case" mean? :)

[kzidane]

Because the class instances we're comparing are singleton so using either (is or ==) doesn't matter (they should evaluate to the same value).

>>> (type(42) == int) == (type(42) is int)
True