maintaining original sys.stdin #59
Merged
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmalan
requested changes
Oct 31, 2018
| @@ -35,18 +35,21 @@ class Reader: | |||
| https://bugs.python.org/issue24402 | |||
| """ | |||
|
|
|||
| def __init__(self, f): | |||
| self.f = f | |||
There was a problem hiding this comment.
Can/should we rename? Feels a bit magical.
There was a problem hiding this comment.
Was trying to be consistent with what you have here
Line 21 in d03d296
file) passed to the constructor here. We're instantiating a few lines later and passing it sys.stdin, so in the instance that we're using self.f is original sys.stdin.
|
Fixes this bug per the email thread:
|
|
Which happens when using IDLE on Windows at least. |
glennholloway
approved these changes
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.