Skip to content

avoid uppercasing identifiers #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2021
Merged

avoid uppercasing identifiers #149

merged 1 commit into from
Mar 29, 2021

Conversation

kzidane
Copy link
Member

@kzidane kzidane commented Mar 17, 2021

There is a bug in sqlparse where passing keyword_case="upper" to sqlparse.format causes it to uppercase any instances of keyword, even when used as an identifier rather than a keyword. For example:

SELECT 1 AS count;

would end up executing:

SELECT 1 AS COUNT;

This PR removes keyword_case for now.

@kzidane kzidane requested review from dmalan and brianyu28 March 17, 2021 18:36
@dmalan
Copy link
Member

dmalan commented Mar 17, 2021

Is that a known bug in their repo? Or should we open?

@kzidane
Copy link
Member Author

kzidane commented Mar 17, 2021

I think andialbrecht/sqlparse#611 references the same behavior.

@kzidane kzidane merged commit 599d968 into develop Mar 29, 2021
@kzidane kzidane deleted the upper branch March 29, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants