Skip to content

fix small issue in sql.py which cause AttributeError #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

io614
Copy link

@io614 io614 commented Nov 29, 2020

When debug mode is off, sometimes a

AttributeError: '_AppCtxGlobals' object has no attribute '_connection' 

is thrown during operation. This is solved by checking that _connection exists in the flask application context before looking up its value.

@dmalan dmalan self-requested a review November 29, 2020 11:41
@dmalan dmalan self-assigned this Nov 29, 2020
@dmalan dmalan added the bug label Nov 29, 2020
@dmalan
Copy link
Member

dmalan commented Nov 29, 2020

Thanks! Turns out you uncovered some other latent bugs that we're going to fix a bit more thoroughly in #138!

@dmalan dmalan closed this Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants