Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes support for transactions for SQLite, PostgreSQL, and MySQL #133

Merged
merged 12 commits into from
Nov 23, 2020
Merged

Fixes support for transactions for SQLite, PostgreSQL, and MySQL #133

merged 12 commits into from
Nov 23, 2020
+174 −24

Conversation

dmalan
Copy link
Member

@dmalan dmalan commented Nov 22, 2020 •
edited
Loading

Re #118 and #131.

@dmalan dmalan requested a review from kzidane November 22, 2020 16:25
@dmalan dmalan self-assigned this Nov 22, 2020
kzidane
kzidane suggested changes Nov 23, 2020
View reviewed changes
Copy link
Member

@kzidane kzidane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the app teardown handler could still potentially be registered multiple times here btw since the teardown handler does not deregister itself after deleting flask.g._connection.

@dmalan
fixed README
c68324d
@dmalan
corrected syntax in README
083bf5e
@dmalan
detecting PostgreSQL syntax errors
a11c9b9
@dmalan
only calling teardown_appcontext once
727df50
@dmalan
raising ValueError, no longer disconnecting on IntegrityError

Verified

This commit was signed with the committer’s verified signature.
euclio Andy Russell
GPG key ID: BE2221033EDBC374
Verified
Learn about vigilant mode
31305e1
@dmalan
updated tests for ValueError
e8cca8d
@dmalan
updated test for ValueError

Verified

This commit was signed with the committer’s verified signature.
euclio Andy Russell
GPG key ID: BE2221033EDBC374
Verified
Learn about vigilant mode
16e52bf
@dmalan dmalan merged commit e9464d8 into develop Nov 23, 2020
@dmalan dmalan deleted the transactions branch November 23, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzidane kzidane

Assignees

@dmalan dmalan

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmalan @kzidane