Granted permission for root to insert, delete, update on all tables #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Granted permission for root to insert, delete, update on all tables
dmalan
reviewed
Jun 6, 2020
| @@ -19,7 +19,7 @@ def test_delete_returns_affected_rows(self): | |||
| {"id": 3, "val": "baz"} | |||
| ] | |||
| for row in rows: | |||
| self.db.execute("INSERT INTO cs50(val) VALUES(:val);", val=row["val"]) | |||
| self.db.execute("INSERT INTO cs50(val) VALUES(:val);", val=row["val"]) | |||
There was a problem hiding this comment.
Afraid this is incorrectly indented now!
There was a problem hiding this comment.
Oh sorry, I just inccidentaly copied one row :-D
| //Granted permision to root to select, insert, update and delete anything on all tables | ||
| def setUp(self): | ||
| self.db.execute("GRANT SELECT, INSERT, UPDATE, DELETE ON ALL TABLES TO root;") | ||
|
|
There was a problem hiding this comment.
Not sure this is solving an open issue?
| @@ -172,7 +177,7 @@ def setUp(self): | |||
|
|
|||
| def test_lastrowid(self): | |||
| self.db.execute("CREATE TABLE foo(id INTEGER PRIMARY KEY AUTOINCREMENT, firstname TEXT, lastname TEXT)") | |||
| self.assertEqual(self.db.execute("INSERT INTO foo (firstname, lastname) VALUES('firstname', 'lastname')"), 1) | |||
| self.assertEqual(sv elf.db.execute("INSERT INTO foo (firstname, lastname) VALUES('firstname', 'lastname')"), 1) | |||
There was a problem hiding this comment.
Afraid this isn't syntactically valid!
There was a problem hiding this comment.
It supposed to commit changes only at line 163. I will check where it went wrong, why one line is deleted and is changed by the same line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Granted permission for root to insert, delete, update on all tables