Transaction sessions; appcontext teardown fix; multiple databases in request fix. #122
+196
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit modes. Registers Flask appcontext teardown function only once per database instance, and also allows for multiple database connections in a single Flask request. Add unit tests for SQL savepoints, autocommit mode, manual transaction mode. Add integration tests for Flask.
dmalan
requested changes
Jun 4, 2020
…URL variable, and always committing session so as to release locks.
kzidane
suggested changes
Jun 5, 2020
…ance variable to track transaction status, and retaining session between calls to execute, among other things.
kzidane
suggested changes
Jun 6, 2020
There was a problem hiding this comment.
Have we concluded that it's fine to pass BEGIN|START TRANSACTION or COMMIT|ROLLBACK to Session.execute() or is that frowned upon or problematic in anyway? Would it make anything simpler or better if we instead retain sqlalchemy's (and/or the underlying API/driver) default behavior of emitting BEGIN|START TRANSACTION automatically and emitting COMMIT on when Session.commit() (or emitting ROLLBACK when Session.rollback()) is called and simply not pass these statements to Session.execute() and call the appropriate methods instead?
dmalan
requested changes
Jun 7, 2020
|
Okay, sounds good.
|
Closed
This was referenced Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use sessions to handle transactions, allowing for both auto and manual commit modes. Registers Flask appcontext teardown function only once per database instance, and also allows for multiple database connections in a single Flask request.
Add unit tests for SQL savepoints, autocommit mode, manual transaction mode. Add integration tests for Flask.