Skip to content

handles OverflowError in get_float #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2020
Merged

handles OverflowError in get_float #114

merged 1 commit into from
May 4, 2020

Conversation

dmalan
Copy link
Member

@dmalan dmalan commented Feb 19, 2020

No description provided.

@dmalan dmalan added the bug label Feb 19, 2020
@dmalan dmalan self-assigned this Feb 19, 2020
Copy link

@sadikkuzu sadikkuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmalan dmalan requested review from brianyu28 and kzidane May 4, 2020 02:39
@dmalan dmalan merged commit 2f2b23f into develop May 4, 2020
@dmalan dmalan deleted the OverflowError branch May 4, 2020 02:45
@dmalan
Copy link
Member Author

dmalan commented May 4, 2020

Thanks for the reminder, @sadikkuzu!

@sadikkuzu
Copy link

Thanks for the reminder, @sadikkuzu!

My pleasure 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants