added support for optional args for parity with newest C library #11
+56
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzidane
reviewed
Apr 14, 2017
cs50/cs50.py
Outdated
| """Read a line of text from standard input and return it as a string.""" | ||
| try: | ||
| if prompt is not None: | ||
| print(prompt, end="") | ||
| s = sys.stdin.readline() | ||
| return re.sub(r"(?:\r|\r\n|\n)$", "", s) |
There was a problem hiding this comment.
Should return None if not s, since sys.stdin.readline returns "" on EOF?
f.readline() returns an empty string, the end of the file has been reached
https://docs.python.org/2/tutorial/inputoutput.html#methods-of-file-objects
|
Will ponder and loop back! |
|
Closing in favor of #17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent to cs50/libcs50#64.