large inputs not handled

[MuhammadHassanRazaa]

get_string() and get_int() are not accepting large input (i.e. 2048 bits)

[kzidane]

Can you please be more specific? What steps did you take to reproduce this problem?

[MuhammadHassanRazaa]

when i pasted the following number in the input to the command a = get_int('long number'), the number gets truncated to 1/3rd while inputting. here's the video link.

[dmalan]

Hi @MuhammadHassanRazaa, looks like a cmd.exe limitation?

https://docs.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/command-line-string-limitation

[MuhammadHassanRazaa]

@dmalan it can't be cmd.exe limitation. The character count of my input is just 1233, but according to the link you've specified cmd can take 8191 characters once.

Secondly, if it's a cmd limitation, the built-in python input() function shouldn't work.

Looking forward :)

Regards

[dmalan]

Ah, apologies, quite right, I'm seeing a 4096-char limit on Linux. We'll take a look!

[MuhammadHassanRazaa]

No problem, btw I've seen the source code, you guys have used sys.stdin.readline to take input, maybe there's some limitation of this function, changing it to input() may resolve the problem. But I've tested the same code on repl.it, get_int() worked perfectly there. That's why I am confused, maybe there's some limitation of windows and Linux operating system or something else. Regards

…

________________________________ From: David J. Malan <[email protected]> Sent: Tuesday, March 9, 2021 7:29:16 PM To: cs50/python-cs50 <[email protected]> Cc: Muhammad Hassan Raza <[email protected]>; Mention <[email protected]> Subject: Re: [cs50/python-cs50] large inputs not handled (#145) Ah, apologies, quite right, I'm seeing a 4096-char limit on Linux. We'll take a look! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#145 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALKXOMT3LW23ZXRKDEEQKULTCZLGZANCNFSM4Y3LWUXA>.

[kzidane]

Should be fixed in #147.

[dmalan]

Thanks for reporting, @MuhammadHassanRazaa! There may still be platform-specific limitations, though, just fyi!

[MuhammadHassanRazaa]

You're Welcome @dmalan 👍 :). I have tested this code on Kali Linux, Parrot, Windows(cmd and PowerShell) and Ubuntu, it is working perfectly with characters allowed in the respective shell.

Thank you for making the correction :)