fix: test for amount of functions inside test_jar.py file #254
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@curiouskiwi @yuliiazhukovetsHU Are either of you experts at checks? I've never actually written one -- but would love to learn! |
|
Not an expert but happy to work on this together!
Yuliia
…On Sun, Jul 7, 2024 at 9:01 PM Guy E. White ***@***.***> wrote:
@curiouskiwi <https://github.com/curiouskiwi> @yuliiazhukovetsHU
<https://github.com/yuliiazhukovetsHU> Are either of you experts at
checks? I've never actually written one -- but would love to learn!
—
Reply to this email directly, view it on GitHub
<#254 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCJODOBAARWRPOETHCH42TDZLHQGZAVCNFSM6AAAAABKPEJAYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSG4YDMMBYGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
rongxin-liu
assigned
patrickthornton and unassigned
curiouskiwi,
guyewhite and
yuliiazhukovetsHU
|
Thank you for taking the time to submit a pull request, and thanks for pointing out this bug! At some point, we must have patched this bug internally, because the only difference between the suggested file and the current file is that one uses single quotes and the other uses double quotes. We'll make sure the two files match. Thanks again for the help! |
ivanharvard
requested review from
rongxin-liu and
bxngyn
and removed request for
patrickthornton
rongxin-liu
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in test that checks number of functions in jar problem. Bug occurs when number of functions is more than nine because pattern matches only one digit. Now it will match all digits in passed tests.