Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added static lib, gzipped man pages #187

Merged
merged 4 commits into from
Oct 14, 2019
Merged

added static lib, gzipped man pages #187

merged 4 commits into from
Oct 14, 2019

Conversation

kzidane
Copy link
Member

@kzidane kzidane commented Oct 13, 2019

No description provided.

@kzidane kzidane requested review from dmalan and cmlsharp October 13, 2019 19:30
@dmalan
Copy link
Member

dmalan commented Oct 13, 2019

Thanks, @kzidane! Pushed a few tweaks to fix permissions. (And capitalized some comments for consistency.)

Copy link
Member

@dmalan dmalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kzidane, in cli50, if I do

sudo apt-get remove -y libcs50
make deb
sudo dpkg -i build/deb/libcs50_10.1.0_amd64.deb

I get the below warnings?

dpkg: warning: unable to delete old directory '/usr/local/lib': Directory not empty
dpkg: warning: unable to delete old directory '/usr/local/share/man': Directory not empty
dpkg: warning: unable to delete old directory '/usr/local/share': Directory not empty
dpkg: warning: unable to delete old directory '/usr/local/include': Directory not empty
dpkg: warning: unable to delete old directory '/usr/local': Directory not empty

@dmalan
Copy link
Member

dmalan commented Oct 14, 2019

Let’s address warnings first, though?

@kzidane
Copy link
Member Author

kzidane commented Oct 14, 2019

These warnings seem fine. The folders can't be deleted because there's other stuff there (installed by other packages).

@dmalan
Copy link
Member

dmalan commented Oct 14, 2019

Oh I see, it's because remove isn't purging all remnants of the older version. If you do

sudo apt-get purge -y libcs50
make deb
sudo dpkg -i build/deb/libcs50_10.1.0_amd64.deb

there's no warning.

@dmalan dmalan merged commit 2765644 into develop Oct 14, 2019
@dmalan dmalan deleted the static/gzip branch October 14, 2019 18:30
@kzidane
Copy link
Member Author

kzidane commented Oct 14, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants