packagecloud #126
Merged
packagecloud #126
+843
−607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 23, 2018 12:36
dmalan
previously approved these changes
May 23, 2018
| @@ -1,28 +1,71 @@ | |||
| dist: trusty | |||
| sudo: required | |||
| packagecloud: &packagecloud | |||
There was a problem hiding this comment.
This defines a variable of some sort in YAML, allowing us to substitute them later using the <<: *packagecloud syntax to avoid repeating all these key/value pairs.
.travis.yml
Outdated
| token: $PACKAGECLOUD_TOKEN | ||
| local-dir: build/deb | ||
| package_glob: *.deb | ||
| skip_cleanup: true |
There was a problem hiding this comment.
The build directory is not part of the repo. It's a build artifact. Unless this is set to true, I think Travis CI is gonna clean up before deployment, removing the deb.
.travis.yml
Outdated
|
|
||
| # 18.04 | ||
| - <<: *packagecloud | ||
| dist: ubuntu/bionic |
| .nf | ||
| printf(3) | ||
| .fi | ||
| .if n .RE |
There was a problem hiding this comment.
Are we sure we want to maintain these in troff format?
There was a problem hiding this comment.
It's not like we change them that frequently and it'd be nice not to require ruby and asciidoctor to be installed especially for people who are building and installing from source?
added 7 commits
May 23, 2018 14:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: RPM and GitHub Release ...